[wg-windows] Problem (and fix) with Unix.create_process in windows

[Leonardo Laguna Ruiz]

I was curious about what Qt makes when calling a process, since we have used Qt in windows without problems when calling processes. Seems that they do exactly what my fix makes:

https://github.com/Vitallium/qt5/blob/master/qtbase/src/corelib/io/qprocess_win.cpp

I would assume that this change is safe and compatible since it has been in Qt for a while.

Leonardo

> On 01 Sep 2015, at 15:20, Daniel Bünzli <daniel.buenzli at erratique.ch> wrote:
> 
>> Le mardi, 1 septembre 2015 à 14:01, Leonardo Laguna a écrit :
>> Has anyone had these kind of problems?
> 
> Not yet.  
> 
>> Is is possible to get this change in the ocaml code?
> This surely qualifies as bug. No escaping should be needed on Unix.create_process and whathever you give as arguments should end up in the sub process' Sys.argv as given. A mantis http://caml.inria.fr/mantis/ issue and a patch (possibly on github) are likely most welcome.  
> 
> FWIW I have this link about the problem [1] I intended to study at a certain point. It might be worth giving it a read.  
> 
> Best,
> 
> Daniel
> 
> [1] http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/everyone-quotes-arguments-the-wrong-way.aspx
> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ocaml.org/pipermail/wg-windows/attachments/20150901/20d822fe/attachment.html>